Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(product): fix add OFF button if product not found #389

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Feb 27, 2024

What

In the product detail page, when the product is not found, we just show a message in red.

This PR does a few things :

  • adds a button to OFF
  • changes the title to "" instead of "unknown product name"

Closes #177

Screenshot

Before After
image image

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the string to "Add this product to Open Food Facts" ?
Also, in some cases, this will be an OPF/OBF/OPFF product, so ideally several buttons

@raphodn
Copy link
Member Author

raphodn commented Feb 28, 2024

Could we change the string to "Add this product to Open Food Facts" ?

ok !

Also, in some cases, this will be an OPF/OBF/OPFF product, so ideally several buttons

I think it requires a seperate discussion, I don't want to add to many buttons right now

@raphodn raphodn merged commit f7c7258 into master Feb 28, 2024
2 checks passed
@raphodn raphodn deleted the raphodn/product-not-found-add-off-button branch February 28, 2024 08:31
raphodn added a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Product not found : add a link to OFF
2 participants