feat: new dialog to set RECEIPT as private #404
Conversation
src/components/ProofFooter.vue
Outdated
| @@ -15,7 +15,9 @@ | |||
| </v-chip> | |||
| <PriceCountChip :count="proof.price_count" :withLabel="true" @click="goToProof()"></PriceCountChip> | |||
| <RelativeDateTimeChip :dateTime="proof.created"></RelativeDateTimeChip> | |||
| <ProofIsPublicChip v-if="proof.type === 'RECEIPT'" :proof="proof"></ProofIsPublicChip> | |||
There was a problem hiding this comment.
my 2 cents : in terms of UX, I wouldn't mix tags and forms/actions.
- currently there's info tags on the left, and a delete button on the right
- i would rather add an extra "edit" button : clicking opens up a dialog, owner can edit both the type & the public/private
- and maybe put the delete inside it as well in the long term ? (or not, haven't given much thought on it yet)
Moving things to a dialog allows adding extra info to the user :
- explain what "a private proof" means
- explain that the "private feature" is only available for receipts (and the toggle could be set to readonly for other proofs)
- a cancel button to avoid misclicks
There was a problem hiding this comment.
also it's missing some kind of userCanEditProof or isProofOwner
There was a problem hiding this comment.
to go even further in the reflexion, this could be 2 PR :
- 1 to display the public or private information (as an owner & as an other user)
- 1 to edit this information (if you are the owner)
There was a problem hiding this comment.
I agree, we should rethink the proof page and the rest as the app becomes more complex. We are close to needing a big UI/UX research phase.
I am not sure I understand what you mean by:
also it's missing some kind of userCanDeleteProof or isProofOwner
Do you mean we can use those methods outside the proof page?
Right now, only the user can see a proof that he uploaded and that has no price associated (thus can be deleted). A deletable proof is never seen by other users.
When checking a proof associated by a price by clicking the proof chip, we can just return a tooltip saying that it is private if not the owner. This just needs an assertion of proof.owner on click.
Following this PR, 2 more will follow:
- Set proof as private when adding from a "Add Price Receipt" form. Still hesitating if I should pass it in proofCreate or proofUpdate. Since proof gets uploaded right after selection, the parameter is_public has to be chosen by the user before the selection, which is counter-intuitive. My thought is to add a toggle or checkbox showing up once proof is uploaded to mark it as private.
- Disable non owners to see a private proof as mentioned above
There was a problem hiding this comment.
as mentionned above, there should be a check userCanEditProof
for example, in the latest prices, any user can see the price proofs
There was a problem hiding this comment.
Alright, it's my point 2
Disable non owners to see a private proof as mentioned above
I will start working on that
src/components/ProofFooter.vue
Outdated
| @@ -29,7 +31,9 @@ export default { | |||
| components: { | |||
| 'PriceCountChip': defineAsyncComponent(() => import('../components/PriceCountChip.vue')), | |||
| 'RelativeDateTimeChip': defineAsyncComponent(() => import('../components/RelativeDateTimeChip.vue')), | |||
| 'ProofDeleteChip': defineAsyncComponent(() => import('../components/ProofDeleteChip.vue')) | |||
| 'ProofDeleteChip': defineAsyncComponent(() => import('../components/ProofDeleteChip.vue')), | |||
| 'ProofIsPublicChip': defineAsyncComponent(() => import('../components/ProofisPublicChip.vue')) | |||
There was a problem hiding this comment.
| 'ProofIsPublicChip': defineAsyncComponent(() => import('../components/ProofisPublicChip.vue')) | |
| 'ProofIsPublicChip': defineAsyncComponent(() => import('../components/ProofIsPublicChip.vue')) |
src/components/ProofFooter.vue
Outdated
| @@ -15,7 +15,9 @@ | |||
| </v-chip> | |||
| <PriceCountChip :count="proof.price_count" :withLabel="true" @click="goToProof()"></PriceCountChip> | |||
| <RelativeDateTimeChip :dateTime="proof.created"></RelativeDateTimeChip> | |||
| <ProofIsPublicChip v-if="proof.type === 'RECEIPT'" :proof="proof"></ProofIsPublicChip> | |||
There was a problem hiding this comment.
as mentionned above, there should be a check userCanEditProof
for example, in the latest prices, any user can see the price proofs
dq18
changed the title
What
Thanks to #401 there is an API endpoint to update some proof fields. User can now edit their RECEIPT proofs in Dashboard Proof page by opening a dialog.
This dialog can further include:
Part of #363