Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(product): if quantity missing, show warning color & tooltip #412

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Mar 6, 2024

What

Currently, if the product quantity info is missing, we simply hide the ProductQuantityChip chip + don't calculate the price per kg/L.

But we could also show a "warning" message to nudge users to edit the info in OFF :)

Add a tooltip on hover

Screenshot

image

@raphodn raphodn self-assigned this Mar 6, 2024
@raphodn raphodn requested a review from dq18 March 6, 2024 20:58
@raphodn raphodn force-pushed the raphodn/product-quantity-missing branch from 9f4e6c4 to f88de19 Compare March 8, 2024 12:39
@raphodn raphodn force-pushed the raphodn/product-quantity-missing branch from f88de19 to 7ccd42c Compare March 9, 2024 08:02
@raphodn raphodn changed the title feat(product): show warning color if product quantity missing feat(product): if quantity missing, show warning color & tooltip Mar 9, 2024
@raphodn raphodn merged commit d4ce6ce into master Mar 9, 2024
4 checks passed
@raphodn raphodn deleted the raphodn/product-quantity-missing branch March 9, 2024 08:07
@raphodn raphodn linked an issue Mar 9, 2024 that may be closed by this pull request
5 tasks
@raphodn raphodn mentioned this pull request Mar 9, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Better show missing product data
1 participant