Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(price): new action menu if user is owner (to delete, and soon edit) #442

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Mar 14, 2024

What

New PriceActionMenuButton component
Move Delete action to PriceDeleteConfirmationDialog

Screenshot

Screenshot from 2024-03-14 16-03-10

@raphodn raphodn marked this pull request as ready for review March 15, 2024 16:24
@raphodn raphodn requested a review from dq18 March 15, 2024 16:24
})
},
removePriceCard() {
document.getElementById(`price_${this.price.id}`).remove()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue we had with proofs
image
An alternative is to keep in store but find a way to update the store when the database is updated to avoid something like #438

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, created an issue #449

@raphodn raphodn changed the title feat(price): new action menu (edit, delete) feat(price): new action menu if user is owner (to deleted, and soon edit) Mar 16, 2024
@raphodn raphodn changed the title feat(price): new action menu if user is owner (to deleted, and soon edit) feat(price): new action menu if user is owner (to delete, and soon edit) Mar 16, 2024
@raphodn raphodn merged commit 0e40e0c into master Mar 16, 2024
4 checks passed
@raphodn raphodn deleted the raphodn/price-actions branch March 16, 2024 08:51
@raphodn raphodn linked an issue Mar 16, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow users to edit/update their prices
2 participants