Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: price create form: improve a bit the proof upload (responsive, overflow, icon) #49

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Dec 22, 2023

What

Proof upload form changes:

  • change icon (square -> circle)
  • avoid overflow
  • responsive : display image on the right column on bigger screens
  • improve loading (hide error, show success)

@raphodn raphodn self-assigned this Dec 22, 2023
@teolemon
Copy link
Member

During my days off, I took the time to try the UI. Something that would be awesome on proof upload would be to attempt to extract a barcode, and prefill the barcode field.

@raphodn raphodn force-pushed the raphodn/proof-upload-improvements-2 branch from 91dbffc to ec7061a Compare December 22, 2023 13:05
@raphodn
Copy link
Member Author

raphodn commented Dec 22, 2023

During my days off, I took the time to try the UI. Something that would be awesome on proof upload would be to attempt to extract a barcode, and prefill the barcode field.

Yes definitely ! We talked about it on wednesday, can you create an issue in the backend repo ? the server could answer with info such as the barcode, the price, the product_name...

@raphodn raphodn changed the title feat: improve proof upload form (responsive, overflow, icon) feat: price create form: improve a bit the proof upload (responsive, overflow, icon) Dec 22, 2023
@raphodn raphodn merged commit 83e54df into master Dec 22, 2023
@raphodn raphodn deleted the raphodn/proof-upload-improvements-2 branch December 22, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants