Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The top bar button spans the entire screen instead of only the area you'd expect it to #553

Closed
odin-h opened this issue Apr 24, 2024 · 3 comments · Fixed by #562
Closed
Labels
🐛 bug Something isn't working

Comments

@odin-h
Copy link
Collaborator

odin-h commented Apr 24, 2024

What

The "Open Prices" button in the top bar is not limited to the width of the text/logo, which could lead you to accidentally click the "home" button when you only wanted to click the top bar to remove the focus from an input field or something.

Steps to reproduce the behavior:

  1. Go to a page that is not the home page e.g. the latest prices page.
  2. Click a part of the top bar that's not on the Open Prices logo or text.
  3. Get taken to the home page despite not clicking where the button is displayed in the UI.

Expected behavior

Only the area with the logo and text of the top bar should act as the button. Clicking this button should maybe also prompt the user to confirm using the onbeforeunload event listener if you have unsaved work. Like when adding new prices.

Screenshots

image

Platform (Desktop, Mobile, Hunger Games)

  • Platform Desktop

Part of

@odin-h odin-h added the 🐛 bug Something isn't working label Apr 24, 2024
@raphodn
Copy link
Member

raphodn commented Apr 28, 2024

I see, fixed 👍

@raphodn
Copy link
Member

raphodn commented Apr 28, 2024

When clicking in the space between the blank spaces, do you expect a behavior ? like scrolling to the top ?

@odin-h
Copy link
Collaborator Author

odin-h commented Apr 29, 2024

No, not really. Just found myself accidentally clicking it way too often when trying to change window and such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants