Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store & sync the product categories from OFF #154

Closed
Tracked by #39
raphodn opened this issue Jan 19, 2024 · 3 comments · Fixed by #192 or #234
Closed
Tracked by #39

Store & sync the product categories from OFF #154

raphodn opened this issue Jan 19, 2024 · 3 comments · Fixed by #192 or #234
Labels
Categories Product data sync ✅ Task

Comments

@raphodn
Copy link
Member

raphodn commented Jan 19, 2024 •
edited
Loading

Story

To better compare products, the category is a good info to store

How ?

We could store the last category known in the categories_hierarchy field ?
Better : the full categories_tags list (what is the difference with categories_hierarchy ?)

image
@teolemon teolemon mentioned this issue Jan 25, 2024
Open
@raphodn
Copy link
Member Author

raphodn commented Jan 26, 2024

@raphael0202 categories_tags or categories_hiararchy ?

@raphael0202
Copy link
Contributor

I think category_hierarchy is just an ordered view (based on hierarchy) of categories_tags. On Robotoff we always use categories_tags.

@raphodn raphodn linked a pull request Feb 15, 2024 that will close this issue
feat: new Product.categories_tags array field #192
Merged
@raphodn
Copy link
Member Author

raphodn commented Feb 21, 2024

done in #192 + additional fix in 9402bbb

@raphodn raphodn closed this as completed Feb 21, 2024
This was referenced Feb 21, 2024
Closed
Merged
Closed
@raphodn raphodn linked a pull request Mar 5, 2024 that will close this issue
feat(products): new filter by categories_tags #234
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Categories Product data sync ✅ Task
Projects
💸 Open Prices
Status: Done
Milestone
No milestone
3 participants
@teolemon @raphodn @raphael0202