Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The scanner does not respect the language of the phone #1981

Open
teolemon opened this issue Oct 22, 2018 · 1 comment
Open

The scanner does not respect the language of the phone #1981

teolemon opened this issue Oct 22, 2018 · 1 comment
Labels
bug Produces incorrect or unexpected result or behaviour. scanning

Comments

@teolemon
Copy link
Member

The scanner does not respect the language of the phone.
If a product is available in English and Spanish, with English as the main language, but Spanish as the language of the app, the product will be displayed in English.
The app should display the product in Spanish.

@teolemon teolemon added the bug Produces incorrect or unexpected result or behaviour. label Oct 25, 2018
@jaindiv26
Copy link
Contributor

@teolemon Yes, the scanner does not respect the language of the phone, because it's depends on the app language. Whatever the language of the phone is, the app will always follow it's own language. But what we can do is, at the time of first time opening of the app, we run this line "Locale.getDefault().getDisplayLanguage();" to get the device language and set it as default of the app language.

For example when the app is first run in the phone and the phone language is Espanol we get the device language and set the same in the app. Afterwards whatever the user changes the language of the app, it's his/her choice.

And the product is displayed according to the app language. See screenshots.
screenshot_2018-12-29-22-05-38-911_openfoodfacts github scrachx openfood
screenshot_2018-12-29-22-06-26-625_openfoodfacts github scrachx openfood
screenshot_2018-12-29-22-06-50-842_openfoodfacts github scrachx openfood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Produces incorrect or unexpected result or behaviour. scanning
Projects
Status: No status
Development

No branches or pull requests

2 participants