Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Scan card should show the product in the language of the app when available #2171

Open
teolemon opened this issue Jan 28, 2019 · 2 comments
Open

The Scan card should show the product in the language of the app when available #2171

teolemon opened this issue Jan 28, 2019 · 2 comments
Labels
bug Produces incorrect or unexpected result or behaviour. multilingual products The viewing and editing of multi lingual products needs-sample-product scanning

Comments

@teolemon
Copy link
Member

Fast scan should show the product in the language of the app when available
That means calling for an additional field in the short query, and showing it instead if not empty
product_name_ + lang of the UX
@balaji-ramavathu
Copy link
Contributor

I'll work on it. By fast scan you mean scan card right?

@balaji-ramavathu
Copy link
Contributor

balaji-ramavathu commented Feb 17, 2019 •
edited

@teolemon I think the work done in the pull #2163 is similar to the work needed to solve this issue as this issue requires getting a field name in the language of the app, which was implemented in that PR. So rather than doing the same work again, it's better if that PR gets merged, so that we can use that code to fix this.

@teolemon teolemon added multilingual products The viewing and editing of multi lingual products scanning labels Mar 3, 2019
@teolemon teolemon added the bug Produces incorrect or unexpected result or behaviour. label Dec 26, 2019
@teolemon teolemon changed the title Fast scan should show the product in the language of the app when available The Scan card should show the product in the language of the app when available Dec 26, 2019
@teolemon teolemon removed the P1 label May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Produces incorrect or unexpected result or behaviour. multilingual products The viewing and editing of multi lingual products needs-sample-product scanning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teolemon @balaji-ramavathu