Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The app shouldn't ask for Best Before Date on product addition #3124

Open
teolemon opened this issue May 16, 2020 · 1 comment
Open

The app shouldn't ask for Best Before Date on product addition #3124

teolemon opened this issue May 16, 2020 · 1 comment
Labels
bug Produces incorrect or unexpected result or behaviour. product addition

Comments

@teolemon
Copy link
Member

teolemon commented May 16, 2020 •
edited

https://user-images.githubusercontent.com/8158668/81541861-1372c700-9374-11ea-9304-97ca7c6df195.png

Not sure if this is related to the new version: when I add a new product, the focus is on the "Expiration date" field, I don't see the top of the form.

Also, I think this field should be removed from the mobile app.

This is blocked on the resolution of #3072 to avoid potential merge conflicts
@teolemon teolemon added product addition bug Produces incorrect or unexpected result or behaviour. labels May 16, 2020
@teolemon teolemon mentioned this issue May 16, 2020
Merged
@kartikaysharma01
Copy link
Contributor

kartikaysharma01 commented Jan 20, 2021 •
edited

@teolemon @VaiTon I believe this issue can be closed as the required changes are already made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Produces incorrect or unexpected result or behaviour. product addition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teolemon @kartikaysharma01