-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: The Activity now notifies when the drawer status has changed #4560
Conversation
@g123k small merge conflicts to solve |
@g123k should I keep both imports ? |
Yes you can |
@g123k we should specify that with this approach the activity can only have a fragment listening to the drawer at any given time. Maybe also implement a control on the |
Thanks for your feedback @VaiTon, I will add them |
@VaiTon I've changed my implementation to allow multiple listeners (with a |
Kudos, SonarCloud Quality Gate passed!
|
Sorry for the delay! |
To fix #4540 and more particularly the issue with the focus, I had to make some changes.
Right now, the
MainActivity
has the following lifecycle:The problem here is that the last keyboard event happens after the fragment is added/attached (after the
onResume
).To fix this, the Fragments now can listen to drawer events.
Here is the new lifecycle: