fix: Useless swipe to refresh with an empty product #4608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This view normally holds search results that you can refresh @g123k |
|
Ah the other case could be server issues. |
|
Actually, could we jump directly to the product addition screen ? |
…he camera app should be launched
|
Kudos, SonarCloud Quality Gate passed!
|
teolemon
approved these changes
Mar 25, 2022
|
You're right, it would be better to open the edition screen instead. |
|
Mmmm actually I think we should stay on the current implementation (= this PR is still relevant). How it works right now:
|
|
Merged as a result |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a product doesn't exist, the app shows a dedicated screen to create it.
On this screen, a swipe to refresh is available: but to refresh what?
That's why this PR disables the swipe to refresh