Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When nutriscore is not (yet) computed, hide the "Learn more" button #4657

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

g123k
Copy link
Contributor

@g123k g123k commented Apr 9, 2022

Will fix #4620

@g123k g123k requested a review from a team as a code owner April 9, 2022 06:56
@g123k g123k added bug Produces incorrect or unexpected result or behaviour. ux User experience, issues relating to improvements and changes to aid users nutriscore labels Apr 9, 2022
g123k and others added 2 commits April 9, 2022 13:34
…es/product/view/nutrition/NutritionProductFragment.kt

Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@g123k
Copy link
Contributor Author

g123k commented Apr 14, 2022

@teolemon & @VaiTon If it's ok for both, could we merge this?

@VaiTon VaiTon merged commit a17ddb9 into openfoodfacts:develop Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Produces incorrect or unexpected result or behaviour. nutriscore ux User experience, issues relating to improvements and changes to aid users
Projects
Status: Done
Status: No status
Development

Successfully merging this pull request may close these issues.

Only links and tappable words should be written in blue
2 participants