Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Made "image upload" message more descriptive on Product Addition #4852

Merged

Conversation

pratyaksh1610
Copy link
Contributor

Description

Made "image upload" message more descriptive on Product Addition.

Related issues

fixes #2945

- Added and localised required strings
- Updated height of next button to view the toast
- Added required toasts in fragments
@pratyaksh1610
Copy link
Contributor Author

@VaiTon Sorry for the delay, PTAL. Thanks.

Copy link
Member

@VaiTon VaiTon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor issues

@pratyaksh1610
Copy link
Contributor Author

@VaiTon PTAL. Thanks

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@VaiTon VaiTon merged commit 9bde0f8 into openfoodfacts:develop Oct 5, 2022
@VaiTon
Copy link
Member

VaiTon commented Oct 5, 2022

Thank you @pratyaksh1610!

@pratyaksh1610 pratyaksh1610 deleted the image-upload-message-branch branch October 6, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "image upload" message more explicit on Product Addition
3 participants