Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 617 - user related queries now support api v3 #666

Merged
merged 2 commits into from
Dec 31, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • api_get_user_products_test.dart: now supporting api v3
  • tag_filter.dart: added filters PHOTOGRAPHERS and INFORMERS
  • user_product_search_query_configuration.dart: deprecated

What

  • User related product queries used a specific syntax, that made them incompatible with api v3.
  • Now we use the standard syntax with new parameters.
  • Therefore user related product queries now support api v3.

Fixes bug(s)

Impacted files:
* `api_get_user_products_test.dart`: now supporting api v3
* `tag_filter.dart`: added filters `PHOTOGRAPHERS` and `INFORMERS`
* `user_product_search_query_configuration.dart`: deprecated
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #666 (5001d3f) into master (b6379ce) will decrease coverage by 0.27%.
The diff coverage is 96.82%.

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   76.68%   76.40%   -0.28%     
==========================================
  Files         195      195              
  Lines        7008     7058      +50     
==========================================
+ Hits         5374     5393      +19     
- Misses       1634     1665      +31     
Impacted Files Coverage Δ
lib/src/model/parameter/tag_filter.dart 63.63% <ø> (ø)
lib/src/model/product.dart 77.53% <ø> (ø)
lib/src/model/product_packaging.dart 62.50% <ø> (ø)
lib/src/utils/product_fields.dart 66.66% <ø> (ø)
...utils/user_product_search_query_configuration.dart 0.00% <ø> (-96.78%) ⬇️
lib/src/open_food_api_client.dart 69.15% <75.00%> (+0.09%) ⬆️
lib/src/utils/json_helper.dart 93.90% <75.00%> (-0.97%) ⬇️
lib/src/model/product.g.dart 97.30% <100.00%> (+0.04%) ⬆️
lib/src/model/product_packaging.g.dart 100.00% <100.00%> (ø)
test/api_get_user_products_test.dart 97.61% <100.00%> (+0.32%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monsieurtanuki monsieurtanuki merged commit 11f678a into openfoodfacts:master Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for API v3 Product WRITE requests to add / edit packaging components
3 participants