-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: 658 - api version is now required for barcode and search queries #667
refactor!: 658 - api version is now required for barcode and search queries #667
Conversation
…ueries Impacted files: * `api_get_to_be_completed_products_test.dart`: minor refactoring * `api_matched_product_v2_test.dart`: minor refactoring * `api_search_products_test.dart`: added version * `open_food_api_client.dart`: api version is now required for `getProductFreshness` * `product_query_configurations.dart`: api version is now required for `ProductQueryConfiguration`; deprecated version 0, (1) and 2 * `product_search_query_configuration.dart`: api version is now required for `ProductSearchQueryConfiguration`
❌ test/api_search_products_test.dart: OpenFoodAPIClient search products with/without allergens check products without allergens (failed) package:test_api expect |
Codecov Report
@@ Coverage Diff @@
## master #667 +/- ##
==========================================
- Coverage 76.68% 76.40% -0.28%
==========================================
Files 195 195
Lines 7008 7058 +50
==========================================
+ Hits 5374 5393 +19
- Misses 1634 1665 +31
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It looks like there was a problem on the PROD server at that time. |
Thank you @teolemon! |
Impacted files:
api_get_to_be_completed_products_test.dart
: minor refactoringapi_matched_product_v2_test.dart
: minor refactoringapi_search_products_test.dart
: added versionopen_food_api_client.dart
: api version is now required forgetProductFreshness
product_query_configurations.dart
: api version is now required forProductQueryConfiguration
; deprecated version 0, (1) and 2product_search_query_configuration.dart
: api version is now required forProductSearchQueryConfiguration
What
Fixes bug(s)