fix: more read-only tests on PROD env #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `api_get_robotoff_test.dart`: switched to PROD env * `api_matched_product_v1_test.dart`: switched to PROD env * `ordered_nutrient_test.dart`: switched to PROD env
Impacted file: * `api_search_products_test.dart`: more resilient towards `null` result count
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
=======================================
Coverage 76.38% 76.38%
=======================================
Files 195 195
Lines 7062 7064 +2
=======================================
+ Hits 5394 5396 +2
Misses 1668 1668
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
approved these changes
Jan 9, 2023
|
Thank you @M123-dev for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
api_get_robotoff_test.dart: switched to PROD envapi_matched_product_v1_test.dart: switched to PROD envordered_nutrient_test.dart: switched to PROD envWhat
Screenshot