feat: 719 - Suggestion Manager with suggestions for the latest input #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `api_suggestion_manager_test.dart`: Unit tests for `SuggestionManager` * `suggestion_manager.dart`: Manager that returns the suggestions for the latest input. Impacted files: * `open_food_api_client.dart`: added a comment mentioning `SuggestionManager`. * `openfoodfacts.dart`: exported new file `suggestion_manager.dart`
Deleted file: * `api_get_autocompleted_suggestions_test.dart`: based on a deprecated method Impacted files: * `api_get_suggestions_test.dart`: fixed test * `available_attribute_groups.dart`: now uses `HttpHelper().jsonDecode` * `available_preference_importances.dart`: now uses `HttpHelper().jsonDecode` * `events.dart`: now uses `HttpHelper().jsonDecode` * `folksonomy.dart`: now uses `HttpHelper().jsonDecode` * `http_helper.dart`: new `jsonDecode` method that deals with typical OFF server html error pages * `invalid_barcodes.dart`: now uses `HttpHelper().jsonDecode` * `open_food_api_client.dart`: now uses `HttpHelper().jsonDecode` * `ordered_nutrient_test.dart`: now uses `HttpHelper().jsonDecode` * `product_from_json_test.dart`: now uses `HttpHelper().jsonDecode` * `status.dart`: now uses `HttpHelper().jsonDecode`
Impacted file: * `http_helper.dart`: added the "software error" case to `jsonDecode` method
M123-dev
approved these changes
Apr 1, 2023
There was a problem hiding this comment.
Heyy @monsieurtanuki looks great besides some missing documentation in the README
Also, sorry for my late response, but now I'm done with exams for some time at least :D
| } | ||
|
|
||
| /// cf. https://openfoodfacts.github.io/openfoodfacts-server/reference/api-v3/#get-/api/v3/taxonomy_suggestions | ||
| /// | ||
| /// Consider using [SuggestionManager]. |
There was a problem hiding this comment.
Could you update the README
I will once the code is merged, as I cannot point to the doc of a class that does not exist yet.
| @@ -257,7 +260,7 @@ void main() { | |||
| test('Suggestions for additives', () async { | |||
| List<String> result = await OpenFoodAPIClient.getSuggestions( | |||
| TagType.ADDITIVES, | |||
| language: OpenFoodFactsLanguage.RUSSIAN, | |||
There was a problem hiding this comment.
For some reason the test does not pass anymore in Russian.
As we more or less agreed that it was more relevant to run integration tests with server data than unit tests with local json files, once in a while we have to "fix" tests.
|
Thank you @M123-dev for your review! |
|
@M123-dev When is the doc refreshed btw? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New files:
api_suggestion_manager_test.dart: Unit tests forSuggestionManagersuggestion_manager.dart: Manager that returns the suggestions for the latest input.Impacted files:
open_food_api_client.dart: added a comment mentioningSuggestionManager.openfoodfacts.dart: exported new filesuggestion_manager.dartWhat
SuggestionManagerthat was needed for autocomplete widgets.getSuggestionsmethod (typically, when the oldest call takes more time than a more recent call).Fixes bug(s)