Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: new "KP action" enum #730

Merged

Conversation

monsieurtanuki
Copy link
Contributor

New file:

  • knowledge_panel_action.dart: Possible needed contribute actions.

Impacted files:

  • knowledge_panel_element.dart: deprecated const String in favor of the new enum
  • openfoodfacts.dart: exported the new file

What

  • Simple refactoring, using OffTagged

Fixes bug(s)

New file:
* `knowledge_panel_action.dart`: Possible needed contribute actions.

Impacted files:
* `knowledge_panel_element.dart`: deprecated const String in favor of the new enum
* `openfoodfacts.dart`: exported the new file
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @monsieurtanuki

@monsieurtanuki monsieurtanuki merged commit ea52e84 into openfoodfacts:master May 23, 2023
4 of 5 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring from smoothie (KP element)
2 participants