Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 741 - new parameters for Robotoff #743

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • New parameters for Robotoff
    • server type (which opens robotoff questions to OpenBeautyFacts, for instance)
    • "order by" for questions (so far we only used "random", and now we can use "confidence" and "popularity")
    • added and fixed the country parameter - now we can ask robotoff questions filtered by country and language

Fixes bug(s)

Files

New files:

  • robotoff_question_order.dart: Order for Robotoff questions.
  • server_type.dart: Type of Server (e.g. "food facts", "beauty facts", ...).

Impacted files:

  • api_get_robotoff_test.dart: refactored
  • insight.dart: refactored as OffTagged
  • openfoodfacts.dart: exported the new 2 files.
  • robot_off_api_client.dart: deprecated getRandomQuestions in favor of new method getQuestions; new parameters for getRandomInsights, getProductInsights and getProductQuestions

New files:
* `robotoff_question_order.dart`: Order for Robotoff questions.
* `server_type.dart`: Type of Server (e.g. "food facts", "beauty facts", ...).

Impacted files:
* `api_get_robotoff_test.dart`: refactored
* `insight.dart`: refactored as `OffTagged
* `openfoodfacts.dart`: exported the new 2 files.
* `robot_off_api_client.dart`: deprecated `getRandomQuestions` in favor of new method `getQuestions`; new parameters for `getRandomInsights`, `getProductInsights` and `getProductQuestions`
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monsieurtanuki monsieurtanuki merged commit 77c01de into openfoodfacts:master Jun 13, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants