fix: issue with JSON conversion of packagings data #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwvj
requested review from
monsieurtanuki,
PrimaelQuemerais,
M123-dev and
MohamedFBoussaid
g123k
reviewed
Jul 18, 2023
monsieurtanuki
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Hi @peterwvj!
The code itself looks good, but you removed important ignore statements in generated files. Please put them back so that the code analyze works.
And consider my other comments ;)
|
@monsieurtanuki thank you for your great PR feedback. I've implemented all of your suggestions in commit df353be |
monsieurtanuki
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Thank you @peterwvj for this PR and the changes after my review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #752
After adding the proposed fix, I did run into some issues regenerating the *.g.dart files using build_runner but I managed to fix that by upgrading the SDK dependencies according to the instructions described here.