feat: Registration/Password lost: better catch 504 errors from the server #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
==========================================
- Coverage 73.16% 73.00% -0.16%
==========================================
Files 203 203
Lines 7407 7408 +1
==========================================
- Hits 5419 5408 -11
- Misses 1988 2000 +12
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
reviewed
Aug 8, 2023
Comment on lines
+1230
to
+1231
| /// Trigger real 5xx errors | ||
| return status; |
There was a problem hiding this comment.
Say the status is 502 then this case would never trigger. Everything in the besides 500 Returns a 400
Is that your wanted behavior
There was a problem hiding this comment.
Oops my bad, I created this PR while discussing and clearly that was not a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
Due to the current situation with the infrastructure, we often have 504 errors.
Here is a better catch of the errors for the registration and the password lost.
It's here limited to the user management, but it's more critical here.