feat: Multipart requests: ensure to always get the full response #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teolemon
reviewed
Aug 9, 2023
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
teolemon
approved these changes
Aug 9, 2023
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
==========================================
- Coverage 73.11% 73.03% -0.08%
==========================================
Files 203 203
Lines 7408 7416 +8
==========================================
Hits 5416 5416
- Misses 1992 2000 +8
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
We have a major issue with POST requests, where we only get a part of the response (
firstfrom aStream).This PR ensures to get the full response