Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit test values #783

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Minor fixes about unit tests that rely on actual data. The data changed, we slightly change our tested values.

@codecov-commenter
Copy link

Codecov Report

Merging #783 (eb03b3a) into master (4043044) will decrease coverage by 0.11%.
Report is 3 commits behind head on master.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
- Coverage   73.11%   73.00%   -0.11%     
==========================================
  Files         203      203              
  Lines        7408     7417       +9     
==========================================
- Hits         5416     5415       -1     
- Misses       1992     2002      +10     
Files Changed Coverage Δ
lib/src/open_food_api_client.dart 49.68% <0.00%> (-0.16%) ⬇️
test/api_get_to_be_completed_products_test.dart 97.05% <ø> (ø)
test/api_search_products_test.dart 87.15% <ø> (ø)
lib/src/utils/http_helper.dart 72.15% <73.33%> (-1.09%) ⬇️
test/api_get_taxonomy_ingredients_server_test.dart 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@peterwvj peterwvj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@monsieurtanuki
Copy link
Contributor Author

Thank you @peterwvj for your review!

@monsieurtanuki monsieurtanuki merged commit 61c1ec1 into openfoodfacts:master Aug 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants