Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: method to get the Uri host (e.g. for ping) #800

Merged
merged 1 commit into from
Sep 7, 2023
Merged

feat: method to get the Uri host (e.g. for ping) #800

merged 1 commit into from
Sep 7, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • This is a method we had to implement in Smoothie.
  • Typical use-case: trying to ping the server after a connection failed.
  • Now we can get the uri host directly.

Impacted file

  • uri_helper.dart: new getUriHost method

@monsieurtanuki
feat: method to get the Uri host (e.g. for ping)
f441164 
Impacted file:
* `uri_helper.dart`: new `getUriHost` method
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner September 7, 2023 15:01
teolemon
teolemon approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @g123k is about to open a related issue in Smoothie (pinging other servers when the product is not found in Open Food Facts)

@monsieurtanuki monsieurtanuki merged commit 081f0b9 into openfoodfacts:master Sep 7, 2023
5 checks passed
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Sep 7, 2023
Merged
@monsieurtanuki
Copy link
Contributor Author

Nice, @g123k is about to open a related issue in Smoothie (pinging other servers when the product is not found in Open Food Facts)

Thank you @teolemon for your reviews!

The thing is that we don't have the other servers' hosts for the moment.
Do we use the same world.openfoodfacts.org host for all, or different hosts? Something like

  • world.openbeautyfacts.org
  • world.openpetfoodfacts.org
  • world.openproductsfacts.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@monsieurtanuki monsieurtanuki

Labels
None yet
Projects
Dart package - Support for new APIs and issues
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@monsieurtanuki @teolemon