fix: 816 - use localized versions of productName and ingredientsText #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `api_get_save_product_test.dart`: removed tests on productName and ingredientsText; refactored * `product.dart`: added comments about using rather the localized fields for productName and ingredientsText
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
==========================================
+ Coverage 75.59% 76.22% +0.63%
==========================================
Files 205 205
Lines 7580 7537 -43
==========================================
+ Hits 5730 5745 +15
+ Misses 1850 1792 -58
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
g123k
approved these changes
Oct 28, 2023
There was a problem hiding this comment.
Seems indeed better to add explanations in the SDK.
Thanks @monsieurtanuki!
Thank you @g123k for your review! If you have time please consider reviewing openfoodfacts/smooth-app#4746 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
productNameandingredientsTextcould not be 100% trusted anymore in a multilingual context.productName. And as a fallback,productName.ingredientsText.Fixes bug(s)
Impacted files
api_get_save_product_test.dart: removed tests on productName and ingredientsText; refactoredproduct.dart: added comments about using rather the localized fields for productName and ingredientsText