New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sanoid_check.sh to take into account recursivity #306

Closed

alexgarel opened this issue Feb 8, 2024 · 1 comment

Member

alexgarel commented Feb 8, 2024

sanoid_check.sh is a bit naive in parsing sanoid.conf and can't account for recursive=true, while I know use it a lot, because it's less error prone.

I propose to change in this way:

in sanoid.conf we add a comment line to tell which ZFS are not snapshoted regularly (not handled by sanoid)
in sanoid_check.sh we check every ZFS but the exceptions

Overall, it will be much more robust.

alexgarel closed this as completed in

b44240f

Member Author

alexgarel commented Feb 9, 2024

I re-open until it's also deployed to off1 and off2

alexgarel reopened this

alexgarel closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment