Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Support for Code 128 Barcodes #563

Open
bredowmax opened this issue Feb 1, 2020 · 8 comments
Open

Support for Code 128 Barcodes #563

bredowmax opened this issue Feb 1, 2020 · 8 comments

Comments

@bredowmax
Copy link

Summary:
Some products (mostly freshly packaged products with varying weight or price) have Code 128 barcodes that the OFF app does not currently support. The Scandit app does find it

Screenshots:
Screenshot 2020-02-01 at 16 08 58

What is Code 128?
https://en.wikipedia.org/wiki/Code_128

Slack
https://openfoodfacts.slack.com/archives/C02SSQ02N/p1580590985010200

@bredowmax bredowmax changed the title Support for Code 128 Barcodes Feature request: Support for Code 128 Barcodes Feb 1, 2020
@bredowmax
Copy link
Author

Another example, this time in Germany: https://world.openfoodfacts.org/product/2312251310191757006523

@aleene
Copy link
Collaborator

aleene commented Feb 2, 2020

This is a "feature" of the barcodescanner that OFF uses. Or does is this not seen as a valid code? My app does recognizes this code.

@bredowmax
Copy link
Author

True, the Edeka example works on my iOS OFF. The WholeFoods one, however, does not get recognised by OFF (Scandit says both codes are a Code 128 code)

@bredowmax
Copy link
Author

The Edeka example has 22 digits, but the Whole Foods example has 27 digits

@aleene
Copy link
Collaborator

aleene commented Feb 2, 2020

Maybe there is a number of digits check.

@teolemon
Copy link
Member

teolemon commented Feb 6, 2020

@bredowmax
Copy link
Author

Thanks @teolemon for the link. Yes, Code128 is on this list! As @aleene pointed out, Code128 is indeed supported - but apparently they can vary in length. A code with 27 digits was unsupported, so it could be a failed checking number test?

@aleene
Copy link
Collaborator

aleene commented Feb 9, 2020

Just checked: Code128 is supported in the IOS app and the Pastrami code is correctly read.

It is also shown in the history.

So for me there is no issue.

@teolemon teolemon changed the title Feature request: Support for Code 128 Barcodes Support for Code 128 Barcodes Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: No status
Development

No branches or pull requests

3 participants