Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: udpate GSOC page #532

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix: udpate GSOC page #532

merged 2 commits into from
Feb 2, 2024

Conversation

alexgarel
Copy link
Member

GSoC is coming !

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly grammarly suggestion

I don't think breaking space impacts the layout. To simplify Github suggestion process, I tend to always break space at the end of a sentence such that 1 sentence = 1 line and so reviews can add suggestions at the sentence level

@@ -1,6 +1,6 @@
<!-- no side column -->

<h1>Open Food Facts - Google Summer of Code (GSOC) 2023</h1>
<h1>Open Food Facts - Google Summer of Code (GSOC)</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1>Open Food Facts - Google Summer of Code (GSOC)</h1>
<h1>Open Food Facts - Google Summer of Code (GSOC) 2024</h1>

Maybe it's a good practice to make sure the document is updated each year, to appapt to GSoC rule modification

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huuum, I was more on the verge of avoiding this page to decay ;-)

Those are most best practice that we decided.

lang/en/texts/google-summer-of-code.html Outdated Show resolved Hide resolved
lang/en/texts/google-summer-of-code.html Outdated Show resolved Hide resolved
lang/en/texts/google-summer-of-code.html Outdated Show resolved Hide resolved
lang/en/texts/google-summer-of-code.html Outdated Show resolved Hide resolved
lang/en/texts/google-summer-of-code.html Outdated Show resolved Hide resolved
lang/en/texts/google-summer-of-code.html Outdated Show resolved Hide resolved
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@alexgarel
Copy link
Member Author

Thanks a lot @alexfauquette 🙌

@alexgarel alexgarel merged commit 3032104 into main Feb 2, 2024
3 checks passed
@alexgarel alexgarel deleted the fix-gsoc-page branch February 2, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants