Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle umbrella and sub-brands #64

Closed
Tracked by #600
hangy opened this issue Jun 25, 2019 · 4 comments
Closed
Tracked by #600

Better handle umbrella and sub-brands #64

hangy opened this issue Jun 25, 2019 · 4 comments

Comments

@hangy
Copy link
Member

hangy commented Jun 25, 2019

Gut & Günstig is a brand sold in Edeka stores. As it's produced for Edeka, this is mentioned on the packaging a lot. Robotoff sees it and matches the regex to Edeka.

It could be useful to not suggest users to add the "Edeka" brand to the products if "Gut & Günstig" is present anywhere on the product (possibly including other images for the same product).

@hangy
Copy link
Member Author

hangy commented Jul 5, 2019

@raphael0202
Copy link
Collaborator

I think we want "mother" brands to be included as well. @teolemon Can you confirm?

@hangy
Copy link
Member Author

hangy commented Nov 15, 2019

I don't think that would be useful (in ProductOpener). For example, it could drastically skew averages of the "premium" Edeka products in cases where similar products are sold under the child discount brand Gut & Günstig.

@hangy
Copy link
Member Author

hangy commented Nov 18, 2019

cc @stephanegigandet 🙂

@teolemon teolemon changed the title Gut & Günstig vs. Edeka in OCR Better handle umbrella and sub-brands Sep 20, 2022
@openfoodfacts openfoodfacts locked and limited conversation to collaborators Aug 29, 2023
@raphael0202 raphael0202 converted this issue into discussion #1235 Aug 29, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Development

No branches or pull requests

3 participants