feat: Show feedback when special characters are entered in branch name #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NihalRadhakrishna
changed the title
Jagrutiti
reviewed
Feb 14, 2023
nobeeakon
reviewed
Feb 14, 2023
nobeeakon
reviewed
Feb 14, 2023
- modified regex
|
@nobeeakon I have removed the extra state and changed the regex as u suggested. Thanks! |
nobeeakon
reviewed
Feb 14, 2023
|
I have made the necessary changes. Thanks! |
nobeeakon
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Great work!!
Please run prettier and update the PR so we can merge
|
@nobeeakon I ran prettier. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
Part of