feat: Add GET paths for parents and children + fix: Update Neo4J query #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadarsh-ram
changed the title
aadarsh-ram
changed the title
alexgarel
requested changes
Sep 2, 2022
There was a problem hiding this comment.
It's ok but I have one question:
- Changed neo4j query to disallow partial updates
Why do we want this ? Shan't it be a parameter or a specific url ?
Also if we have to push every key / values each time, we should refactor the code, because it can be done in only one query instead of so many.
|
@alexgarel I have now figured out a new way to tackle this. I fetch the current node information and compare it with the node object received, to remove the deleted keys. Does this make sense? |
alexgarel
reviewed
Sep 6, 2022
backend/editor/entries.py
Outdated
| @@ -74,9 +74,20 @@ def update_nodes(label, entry, incomingData): | |||
| if not re.match(r"^\w+$", key) or key == "id": | |||
| raise ValueError("Invalid key: %s", key) | |||
|
|
|||
| # Get current node information and deleted keys | |||
| curr_node = list(get_nodes(label, entry).data()[0]['n'].keys()) | |||
| deleted_keys = list(set(curr_node) ^ set(incomingData)) | |||
There was a problem hiding this comment.
Don't you want to just remove keys where incoming data is null ?
There was a problem hiding this comment.
@alexgarel I added the check.
alexgarel
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
/entry/{entry}/parentsand/entry/{entry}/childrenRelated issue(s)