Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Delete projects when their Github PR is merged #385

Merged
merged 7 commits into from
Feb 7, 2024
Merged

feat: Delete projects when their Github PR is merged #385

merged 7 commits into from
Feb 7, 2024

Conversation

eric-nguyen-cs
Copy link
Contributor

What

  • Add a scheduled task (once a day) to check if the exported project have their PR merged in Github, and if that is the case, then deletes it (deleting a project also now deletes its associated nodes and relationships)

Fixes bug(s)

Fixes https://github.com/orgs/openfoodfacts/projects/103/views/1?pane=issue&itemId=51867390

@eric-nguyen-cs eric-nguyen-cs requested a review from a team as a code owner February 3, 2024 22:00
alexgarel
alexgarel requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great.

The only blocker is the try/except in scheduler.

backend/pyproject.toml Show resolved Hide resolved
backend/editor/scheduler.py Outdated Show resolved Hide resolved
backend/editor/scheduler.py Outdated Show resolved Hide resolved
backend/editor/github_functions.py Show resolved Hide resolved
backend/editor/github_functions.py Show resolved Hide resolved
backend/editor/controllers/node_controller.py Show resolved Hide resolved
backend/editor/api.py Show resolved Hide resolved
alexgarel
alexgarel approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

Pleas, look at the open comments before merging.

@eric-nguyen-cs eric-nguyen-cs merged commit 1304822 into main Feb 7, 2024
7 checks passed
@eric-nguyen-cs eric-nguyen-cs deleted the ericn/delete-projects-when-merged branch February 7, 2024 10:32
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Feb 7, 2024
Merged
@perierc perierc linked an issue Feb 15, 2024 that may be closed by this pull request
Delete projects when merged #384
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@eric-nguyen-cs eric-nguyen-cs

Labels
api backend dependencies PR generation
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete projects when merged
3 participants
@eric-nguyen-cs @alexgarel @teolemon