Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View producer basic details #17

Closed
kirstenalarsen opened this issue Mar 7, 2024 · 7 comments
Closed

View producer basic details #17

kirstenalarsen opened this issue Mar 7, 2024 · 7 comments

Comments

@kirstenalarsen
Copy link

Image

@kirstenalarsen
Copy link
Author

kirstenalarsen commented Mar 7, 2024

When I click into a Producer that has a short profile i.e. not much information, it is scrolling me straight to the bottom so I'm only looking at the footer

Image

and I have to scroll up to see the actual info

Image

This is in the wordpress embed (regenerative.org.au/test) not the SiB staging site so it might be wordpress related @mkllnk

@mkllnk
Copy link
Member

mkllnk commented Mar 12, 2024

@JbPasquier, can you shed some light on this? How does it scroll? Which anchor does it use?

@JbPasquier
Copy link

I found an issue in the SIB Router, I fixed it, Benoît will merge it as soon as he'll be able to review it.

@JbPasquier
Copy link

It has been merged, @mkllnk can you update your WP's head to these lines:

<script type="module" src="https://cdn.skypack.dev/@startinblox/core@0.19"></script>
<script type="module" src="https://cdn.skypack.dev/@startinblox/router@0.12"></script>
<script type="module" src="https://cdn.jsdelivr.net/npm/@startinblox/component-ofn-rpp"></script>

(router@0.12 instead of router@0.11)

@mkllnk
Copy link
Member

mkllnk commented Mar 13, 2024

Yay, it works!

@mkllnk mkllnk closed this as completed Mar 13, 2024
@mariocarabotta
Copy link

  1. location format under the name is not as expected.
    it should be {City} - {State} {First Nations Country}

Note: First Nations Country is optional

Image

  1. if possible, could you please move the tags above the title? We're noticing people adding loads of categories and it breaks the layout. Apologies for this, I was not expecting it.

current
Image

expected (if possible)
Image

  1. Learn more about us needs underline style

  2. Align title and line divider to rest of elements. See below for gaps
    Image

@JbPasquier
Copy link

Done.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants