Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vouchers] Improve presentation of tax discounts in order summary for tax incl. in price #494

Open
drummer83 opened this issue Dec 22, 2023 · 2 comments
Labels
Feature Request Feature request / too big for Papercut

Comments

@drummer83
Copy link

What is the need / problem?

Improvement after openfoodfoundation/openfoodnetwork#10821 (comment) DETAIL 1.

I wasted some time during testing, wondering if the calculation of the app is incorrect. It's correct, but the presentation is very misleading (to me).

If tax is excl. from price we have two adjustments as described here as well. The values are correct but I find it very misleading to have the additional adjustment on tax. The customer can't know if the 4.00 $ in the example below is already the discounted tax or the original tax. He has to calculate himself. Why don't we do that for him by only displaying the final tax paid? I'm not sure if it's technically feasible but we could simply add the original tax and the negative tax discount and display only this result.
image

Which type of users does this problem affect (and how many, if known)?

  • Shoppers
  • TESTERS

Potential solutions that will solve the problem?

Connected wishlist and discovery discussions

Additional context

@RachL RachL added the Potential Papercut Issues that might qualify as papercuts (0.5 days dev) label Jan 4, 2024
@dacook
Copy link
Member

dacook commented Jan 11, 2024

@rioug I suspect you'll be able to answer this quicker than I: is this update a papercut? (simple, uncontroversial change requiring less than 1/2 day dev)

@rioug
Copy link

rioug commented Jan 14, 2024

I'd say it's not a paper cut. It would involve reworking the adjustment display on the checkout page to add additional calculation ( which maybe should be done somewhere else ) for one specific voucher scenario. If you don't know the codebase, you'll have to try understand order adjustments and voucher, which is not straight forward.

@RachL RachL added Feature Request Feature request / too big for Papercut and removed Potential Papercut Issues that might qualify as papercuts (0.5 days dev) labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Feature request / too big for Papercut
Projects
Status: Funded Features Candidates
Development

No branches or pull requests

4 participants