Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor run CLI not respecting --qc-compute-n-cores #130

Closed
jthorton opened this issue Feb 28, 2022 · 2 comments · Fixed by #134
Closed

Executor run CLI not respecting --qc-compute-n-cores #130

jthorton opened this issue Feb 28, 2022 · 2 comments · Fixed by #134
Labels
bug Something isn't working

Comments

@jthorton
Copy link
Contributor

Running the example in the docs using bespokefit version 0.1.0 installed via conda-forge sets up 2 qc workers but gives them both all available cores rather than the 8 specified via the CLI.

@jthorton jthorton added the bug Something isn't working label Feb 28, 2022
@SimonBoothroyd
Copy link
Contributor

@jthorton I'm not sure I can reproduce this. When I run:

openff-bespoke executor run --smiles "CC(=O)NC1=CC=C(C=C1)O" --workflow debug --directory bespoke-fit --n-qc-compute-workers 2 --qc-compute-n-cores 4

for example i see

[2022-03-01 09:49:31,489: INFO/ForkPoolWorker-1] openff.bespokefit.executor.services.qcgenerator.worker.compute_torsion_drive[d8badf49-9ee2-4129-ac39-bf0cd51db32c]: running 1D scan with {'ncores': 4, 'nnodes': 1, 'memory': 32.0}
[2022-03-01 09:49:31,496: INFO/ForkPoolWorker-2] openff.bespokefit.executor.services.qcgenerator.worker.compute_torsion_drive[cbdfa4aa-d66f-4d32-b0c6-11299046ff71]: running 1D scan with {'ncores': 4, 'nnodes': 1, 'memory': 32.0}

in the celery-qcgenerator.log file.

@jthorton
Copy link
Contributor Author

jthorton commented Mar 1, 2022

@SimonBoothroyd thanks for testing this the issue only seems to affect Linux and works as expected for me on mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants