Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of pkg_resources #505

Closed
mattwthompson opened this issue Mar 14, 2023 · 0 comments · Fixed by #542
Closed

Remove use of pkg_resources #505

mattwthompson opened this issue Mar 14, 2023 · 0 comments · Fixed by #542
Assignees

Comments

@mattwthompson
Copy link
Member

pkg_resources is officially-officially deprecated

$ grep -r pkg_re openff                               10:22:46  ☁  main ☂
openff/evaluator/plugins.py:import pkg_resources
openff/evaluator/plugins.py:    for entry_point in pkg_resources.iter_entry_points("openff_evaluator.plugins"):
openff/evaluator/datasets/taproom/taproom.py:import pkg_resources
openff/evaluator/datasets/taproom/taproom.py:        for entry_point in pkg_resources.iter_entry_points(group="taproom.benchmarks"):
openff/evaluator/tests/test_plugins.py:import pkg_resources
openff/evaluator/tests/test_plugins.py:    distribution = pkg_resources.Distribution(__file__)
openff/evaluator/tests/test_plugins.py:    valid_entry_point = pkg_resources.EntryPoint.parse(
openff/evaluator/tests/test_plugins.py:    bad_entry_point = pkg_resources.EntryPoint.parse(
openff/evaluator/tests/test_plugins.py:    pkg_resources.working_set.add(distribution, "dummy_1")
openff/evaluator/tests/test_plugins.py:    pkg_resources.working_set.add(distribution, "dummy_2")
openff/evaluator/utils/utils.py:    from pkg_resources import resource_filename

IIRC the replacement for its entrypoints is found in importlib-metadata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant