Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example demonstrating use of charge_from_molecules #1850

Open
mattwthompson opened this issue Apr 1, 2024 · 0 comments
Open

Add example demonstrating use of charge_from_molecules #1850

mattwthompson opened this issue Apr 1, 2024 · 0 comments

Comments

@mattwthompson
Copy link
Member

Is your feature request related to a problem? Please describe.

Users, especially those adapting OpenFF tools and force fields outside of conventional drug discovery applications, commonly use large molecules for which AM1-BCC takes a long time to run. We have a shortcut charge_from_molecules that effectively allows the user to opt-in to caching these charges. What we don't have, however, is a self-contained example that demonstrates its use (and only its use). I can link to API docs, but it's slightly more involved than that because they need to store the charges alongside a Moleculeobject(s), not just have them in an array somewhere.

Describe the solution you'd like

A relatively short example I can link to instead of explaining it again each time this comes up.

Describe alternatives you've considered

Just repeating myself every time it comes up.

Additional context

Some of us want charge_from_molecules to go away (#806). I'm one of those people. Unfortunately, there's been no movement in years and I don't think we can assume it's going to be removed shortly. Arguably NAGL will makes this obsolete at which point it is released for general use, but I don't believe there's a push to remove charge_from_molecules from the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant