Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Scorer Base Implementation #2

Closed
richardjgowers opened this issue Jan 24, 2022 · 2 comments · Fixed by #26
Closed

Implement Scorer Base Implementation #2

richardjgowers opened this issue Jan 24, 2022 · 2 comments · Fixed by #26
Assignees

Comments

@richardjgowers
Copy link
Contributor

richardjgowers commented Jan 24, 2022

s = Scorer(stuff)

m = Mapper.suggest_mapping(m1, m2)

f : float = s.score(m)
@dwhswenson
Copy link
Member

I can start playing with this one -- for this issue:

  1. Do we just need an abstract base class?
  2. Do we want to implement a ScoreCombiner (or some other name) that takes several Scorers and gives a single output? First version would be sum the scores, but options like max score, geometric mean of scores, etc. would be easy extensions.
  3. We had talked about generalizing the idea of Scorers to Annotators. In this case, maybe we return a dict of annotations, with 'score' being the dict entry used for scores?
  4. If we generalize to Annotators, it will be useful for each Annotator to have some way of communicating what annotations it provides. This could be with a class attribute (List[str]). This attribute could be set by an abstract Scorer class, making it transparent to users for that use case, although I'm not entirely sure that I like that idea.

@richardjgowers
Copy link
Contributor Author

1 yes
2 maybe leave that for now
3 I was thinking of tuple of (score, annotation) so people can easily discard the annotations (it's a bit more specialised)
4 For now this could just be done with docstrings. So just stating the resulting network will be annotated in a certain way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants