Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback magnify - General #61

Closed
PanchoutNathan opened this issue May 17, 2023 · 1 comment
Closed

Feedback magnify - General #61

PanchoutNathan opened this issue May 17, 2023 · 1 comment

Comments

@PanchoutNathan
Copy link
Collaborator

PanchoutNathan commented May 17, 2023

Purpose

Adding and using Cunningham in magnify, I have some thoughts and remarks

Proposal

  • Add Icon section for how to use icons. Where to find them etc
  • Why not add an "" component to simply add the icon name and not the css class (rounded / outlined / default / etc).
  • Export prop types and prop attribute interfaces/types.
@NathanVss
Copy link
Member

Since, we added props exports and we decided that icons does not need any specific component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants