Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/clone_repositories fails to checkout edx-platform on certain platforms #67

Closed
rmoch opened this issue Oct 24, 2018 · 7 comments
Closed

Comments

@rmoch
Copy link
Contributor

rmoch commented Oct 24, 2018

Expected Behavior

bin/clone_repositories script and related Makefile commands should checkout edx-platform in ./src at a given release tag

Actual Behavior

on MacOSX, git 2.19

git checkout -f release-2018-08-29-14.14

fails to checkout revision and returns:

error: pathspec 'release-2018-08-29-14.14' did not match any file(s) known to git.

This is a serious issue because all development commands rely on this script

@amitbend
Copy link

amitbend commented Nov 1, 2018

@rmoch did you find any solution for that?

@jmaupetit
Copy link
Contributor

@amitbend While we are working on it, you can git clone and checkout manually edx/edx-platform. Does the src/edx-platform local repository clone exist on your system?

@amitbend
Copy link

amitbend commented Nov 3, 2018

@jmaupetit yeah, I just cloned it and it seems to work.
I'm trying to figure out how I can edit my theme using the dev-watch command, do I have to ssh into the container?

@jmaupetit
Copy link
Contributor

👋 sorry for my late answer.

No, you don't have to log in to the container (this is not a usual thing in a Docker flow). The dev-watch command is still a draft POC for themes edition. This feature needs to be fully implemented, but, in a few words, you will need to clone or create a git repository for it in the src directory, mount this directory as a volume in the edxapp container (where themes are supposed to be), and invoke the bin/watch script with your theme name (directory) as its first argument.

Definitely, we need to invest more time on this as we all need to improve the developer experience in edx theme development.

@amitbend
Copy link

amitbend commented Nov 6, 2018

@jmaupetit I'll try to implement that although I'm not an expert with docker.
If it will work I'll add instructions here

@jmaupetit
Copy link
Contributor

I'm glad to read this. 🙏

@jmaupetit
Copy link
Contributor

jmaupetit commented Sep 27, 2019

This step/script no longer exists. Closing this as no longer relevant. @amitbend you should give this repository another try: we've strongly smoothed the whole process recently. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants