Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ora2 events #226

Merged
merged 1 commit into from Jun 19, 2023
Merged

Ora2 events #226

merged 1 commit into from Jun 19, 2023

Conversation

quitterie-lcs
Copy link
Member

@quitterie-lcs quitterie-lcs commented Oct 25, 2022 •
edited

Purpose

ORA2 events describe the activity for assessments pair reviewing.
Edx defined models and their selectors are described with Pydantic.

Proposal

Define Pydantic model for:

  • openassessmentblock.create_submission,
  • openassessmentblock.get_peer_submission,
  • openassessmentblock.get_submission_for_staff_grading,
  • openassessmentblock.peer_assess,
  • openassessmentblock.save_submission,
  • openassessmentblock.self_assess,
  • openassessmentblock.staff_assess,
  • openassessmentblock.student_training_assess_example,
  • openassessment.submit_feedback_on_assessments,
  • openassessment.upload_file,

@quitterie-lcs quitterie-lcs self-assigned this Oct 25, 2022
@quitterie-lcs quitterie-lcs marked this pull request as draft October 25, 2022 09:28
@SergioSim SergioSim mentioned this pull request Nov 4, 2022
Closed
@quitterie-lcs quitterie-lcs force-pushed the ora2_events branch 2 times, most recently from d7feaf3 to 0bc566a Compare November 9, 2022 11:41
@quitterie-lcs quitterie-lcs marked this pull request as ready for review November 9, 2022 11:44
@quitterie-lcs quitterie-lcs force-pushed the ora2_events branch 4 times, most recently from 9e003c5 to 877358a Compare November 18, 2022 15:54
SergioSim
SergioSim reviewed Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@SergioSim SergioSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! 💪
Have only some minor questions & suggestions)
Also, here are some ora2 events generated using the learning-analytics-playground to battle-test the models) Sorry for the long delay(

image

src/ralph/models/edx/open_response_assessment/fields/events.py Outdated Show resolved Hide resolved
src/ralph/models/edx/open_response_assessment/fields/events.py Outdated Show resolved Hide resolved
src/ralph/models/edx/open_response_assessment/fields/events.py Outdated Show resolved Hide resolved
src/ralph/models/edx/open_response_assessment/fields/events.py Outdated Show resolved Hide resolved
src/ralph/models/edx/open_response_assessment/fields/events.py Outdated Show resolved Hide resolved
src/ralph/models/edx/open_response_assessment/statements.py Outdated Show resolved Hide resolved
src/ralph/models/edx/open_response_assessment/statements.py Outdated Show resolved Hide resolved
tests/models/edx/open_response_assessment/test_events.py Outdated Show resolved Hide resolved
tests/models/edx/open_response_assessment/test_statements.py Outdated Show resolved Hide resolved
tests/models/edx/open_response_assessment/test_events.py Outdated Show resolved Hide resolved
@quitterie-lcs quitterie-lcs force-pushed the ora2_events branch 3 times, most recently from b76415d to b021f37 Compare December 15, 2022 11:40
@quitterie-lcs quitterie-lcs force-pushed the ora2_events branch 6 times, most recently from 6a6806a to 2a6e029 Compare June 15, 2023 14:50
@quitterie-lcs quitterie-lcs added this to To be reviewed in Roadmap 4.0 Jun 15, 2023
wilbrdt
wilbrdt reviewed Jun 16, 2023
View reviewed changes
Copy link
Contributor

@wilbrdt wilbrdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alt text
Looks good! Just some minor questions/suggestions

CHANGELOG.md Outdated Show resolved Hide resolved
src/ralph/models/edx/open_response_assessment/fields/events.py Show resolved Hide resolved
src/ralph/models/edx/open_response_assessment/fields/events.py Outdated Show resolved Hide resolved
src/ralph/models/edx/open_response_assessment/fields/events.py Outdated Show resolved Hide resolved
src/ralph/models/edx/open_response_assessment/fields/events.py Outdated Show resolved Hide resolved
src/ralph/models/edx/open_response_assessment/fields/events.py Show resolved Hide resolved
wilbrdt
wilbrdt approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@wilbrdt wilbrdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alt text

@quitterie-lcs
✨(models) add edx open response assessment pydantic event models
5e481a0 
ORA2 events describe the activity for assessments pair reviewing.
Edx defined models and their selectors are described with Pydantic.
@quitterie-lcs quitterie-lcs merged commit 587578b into master Jun 19, 2023
21 checks passed
Roadmap 4.0 automation moved this from To be reviewed to Done Jun 19, 2023
@quitterie-lcs quitterie-lcs deleted the ora2_events branch June 19, 2023 16:12
@quitterie-lcs quitterie-lcs removed this from Done in Roadmap 4.0 Jun 20, 2023
@quitterie-lcs quitterie-lcs added this to the 4.0 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilbrdt wilbrdt wilbrdt approved these changes

@SergioSim SergioSim Awaiting requested review from SergioSim

Assignees

@quitterie-lcs quitterie-lcs

Labels
feature needs review
Projects
Ralph roadmap
Status: Done
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quitterie-lcs @wilbrdt @SergioSim