Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying settings on a DataBackend does not update client #539

Open
SergioSim opened this issue Dec 11, 2023 · 0 comments
Open

Modifying settings on a DataBackend does not update client #539

SergioSim opened this issue Dec 11, 2023 · 0 comments

Comments

@SergioSim
Copy link
Collaborator

SergioSim commented Dec 11, 2023

Feature Request

Is your feature request related to a problem or an unsupported use case? Please describe.

The public BaseDataBackend.settings instance attribute can be modified after backend instantiation.
However, once the backend instantiates its client property, any changes to settings do not update client.

Describe the solution you'd like

If changing a backend settings attribute after instantiation is a common use case, I think we should track its state from the client property and update client in case of a change.

Describe alternatives you've considered

Alternatively, we could make settings a "read-only" instance attribute to clarify that modifying it might not have the desired impact).

Or we could improve our documentation, explaining data backend behavior when settings is modified.

Discovery, Documentation, Adoption, Migration Strategy

No major impact.

Do you want to work on it through a Pull Request?

Yes, sure, once a consensus is reached on the desired behavior.

Note

Thanks to @Leobouloc for pointing out this issue in #524 (comment)_

@SergioSim SergioSim changed the title Modifying self.settings on a DataBackend does not update self.client Modifying settings on a DataBackend does not update client Dec 11, 2023
@wilbrdt wilbrdt added this to the 5.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants