Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pricer and pricer-impl #115

Closed
jodastephen opened this issue Apr 16, 2015 · 0 comments · Fixed by #116
Closed

Merge pricer and pricer-impl #115

jodastephen opened this issue Apr 16, 2015 · 0 comments · Fixed by #116
Assignees
Milestone

Comments

@jodastephen
Copy link
Member

Separating the API from the Implementation for pricers is a good idea, but struggles to work in practical terms. The interfaces in pricer are fine, except that they are never likely to have an alternate implementation. Fast pricers will be totally different. And alternate models tend to need to take in different parameters.

Delete strata-pricer-impl and merge all code into strata-pricer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants