Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change geometryType to geometryDimension integer #56

Closed
jerstlouis opened this issue Nov 2, 2021 · 1 comment
Closed

Change geometryType to geometryDimension integer #56

jerstlouis opened this issue Nov 2, 2021 · 1 comment
Labels
CommentPeriod solved but not applied
Projects
TileMatrixSet & Tileset Metadata 2.0

Comments

@jerstlouis
Copy link
Member

We decided to follow this approach in OGC API - Styles ( opengeospatial/ogcapi-styles#30 ) to avoid confusion with the Simple Features geometry types, which e.g. has single / multi flavors. We should re-synchronize the changes here.

Change geometryType to geometryDimension (integer) with values: 0 (points), 1 (curves), 2 (surfaces), 3 (solids), null/not existent (mixed dimension/unknown)
@joanma747
Copy link
Collaborator

This is an easy change that avoid using confusing names (is a line a multilinestring?)

@jerstlouis jerstlouis added this to Received Comments in TileMatrixSet & Tileset Metadata 2.0 Nov 26, 2021
@joanma747 joanma747 moved this from Received Comments to In Progress in TileMatrixSet & Tileset Metadata 2.0 Dec 8, 2021
jerstlouis added a commit to jerstlouis/2D-Tile-Matrix-Set that referenced this issue Dec 10, 2021
@jerstlouis
Clause 8 / TileSet medata; JSON & XML Schemas: Addresses opengeospati…
b58c2d1 
…al#56

- Changing geometryType -> geometryDimensions
@jerstlouis jerstlouis moved this from In Progress to Resolved in TileMatrixSet & Tileset Metadata 2.0 Dec 10, 2021
joanma747 added a commit that referenced this issue Dec 10, 2021
@joanma747
Merge pull request #63 from jerstlouis/master
7a029de 
Fixes for issues #55, #56, #57, #58, #59, #61, #62. Great work! We can close all those issues now.
TileMatrixSet & Tileset Metadata 2.0 automation moved this from Resolved to Done Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CommentPeriod solved but not applied
Projects
TileMatrixSet & Tileset Metadata 2.0
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jerstlouis @joanma747