Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTreeIndex Tests Failure #57

Closed
ajanett opened this issue May 15, 2018 · 4 comments
Closed

RTreeIndex Tests Failure #57

ajanett opened this issue May 15, 2018 · 4 comments
Assignees
Labels

Comments

@ajanett
Copy link
Contributor

ajanett commented May 15, 2018

The Requirement 77 tests, RTreeIndexTests fail consistently in the virtual table test and in the test for update 4. This is due to incorrect regular expression definitions:

  • The virtual table test requires additional backslash characters prior to " in order to properly escape it.
  • The virtual table test should account for additional spaces, or the use of a single quote rather than double quotes.
  • For the virtual table test the following regular expression definition appears to work better: String.format("create\s+virtual\s+table\s+\"?\'?rtree_%s_%s\'?\"?\s+using\s+rtree\s*\(\sid,\sminx,\smaxx,\sminy,\smaxy\s\)", tableName, columnName);
  • The test for update4 trigger is missing critical information within the regular expression. It should be looking for an ... AFTER UPDATE OF ON TABLE ... It is missing the "OF " part.
@ajanett
Copy link
Contributor Author

ajanett commented May 16, 2018

Additionally, the triggers using "INSERT OR REPLACE INTO" cannot be performed and these are also going to fail all of the time. The specification has some strange coloration on these statements possibly indicating a small "or", meaning these should be either INSERT INTO or REPLACE INTO. Typically one will see "INSERT INTO".

@dstenger
Copy link
Contributor

Thank you for reporting.

@jyutzler Can you please do further investigations?

@jyutzler
Copy link
Contributor

@ajanett

Do you have a test file that demonstrates the problem? I have not seen this issue in any of the files that have been provided to this point.

I am also not clear if this a problem with the ETS or the standard. If the problem is in the standard, it needs to be posted to https://github.com/opengeospatial/geopackage.

@ajanett
Copy link
Contributor Author

ajanett commented May 22, 2018

It appears the more recent revisions of the source have corrected the issues I was seeing so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants