Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r10 does not send mandatory SERVICE parameter #11

Closed
mlechner opened this issue Nov 4, 2014 · 10 comments
Closed

r10 does not send mandatory SERVICE parameter #11

mlechner opened this issue Nov 4, 2014 · 10 comments
Assignees
Labels
Milestone

Comments

@mlechner
Copy link

mlechner commented Nov 4, 2014

When testing my WMS for OGC conformity using the testdataset, I do not
see the "large diamond". But the reason seems to be a bug in the testengine:

src does not send the mandatory SERVICE parameter:

I guess this is a bug in the r10 of WMS 1.3 testsuite in team engine 4.0.5

Marco

@segoerke
Copy link
Member

Service parameter is not mandatory for GetMap requests.

@bermud
Copy link
Contributor

bermud commented Nov 21, 2014

See comment from opengeospatial/ets-wms-client13#5

@bermud bermud reopened this Nov 21, 2014
@segoerke
Copy link
Member

This could have a massive impact on every testcase through all the ETSs, as IMHO every testsuite has a related test, to check if for instance a GetMap request is working without that parameter.

@bermud
Copy link
Contributor

bermud commented Jan 29, 2015

@segoerke, talking to OGC staff, it seems that the complaint is valid. We should not enforce the SERVICE parameter. Can you please check how big is the impact?

@bermud
Copy link
Contributor

bermud commented Feb 20, 2015

@segoerke, so if we are going to keep the rule as it is, can you please provide better information/guidance for the tester, inside the tests and when giving back the results? Thank you very much!

@dstenger
Copy link
Contributor

What do you mean with better guidance? We could add a hint to the description of the WMS 1.3.0 ETS. Or a precondition test could be added checking if a GetMap request can be executed without the service parameter (but wouldn't this be too much overhead?).

@bermud
Copy link
Contributor

bermud commented Nov 30, 2015

Add information in the section about how to run the test.

@bermud
Copy link
Contributor

bermud commented May 2, 2016

Please add some information here: /ets-wms13/src/site/markdown/index.md

@dstenger
Copy link
Contributor

Hint about missing service parameter was added and is provided by pull request #31.
This adjustment will be part of the next release.

@dstenger
Copy link
Contributor

dstenger commented Jun 2, 2016

The pull request (#31) was tested successfully, merged to the master branch and will be part of the upcoming release.

@dstenger dstenger closed this as completed Jun 2, 2016
@dstenger dstenger added this to the 1,18 milestone Jun 2, 2016
@dstenger dstenger modified the milestones: 1,18, 1.18 Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants