New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Req 39/43 fail on extensions #295

Closed
jyutzler opened this Issue Feb 26, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@jyutzler
Contributor

jyutzler commented Feb 26, 2017

Extensions are allowed (encouraged) to use tables such as gpkg_tile_matrix and gpkg_tile_matrix_set. However, the way the ATS is written for Requirements 39 (/opt/tiles/gpkg_tile_matrix_set/data/data_values_table_name) and 43 (/opt/tiles/gpkg_tile_matrix/data/data_values_table_name), the test will fail if there are any additional rows in there that don't trace back to the rows with the data_type of "tiles" in gpkg_contents. This means that a GPKG that contains both tiles (and therefore conformed to the tiles conformance class) and 2D gridded coverages would not pass the conformance tests.

For Requirement 39, the test needs to be inverted so that it looks for a row in gpkg_tile_matrix_set for each row in gpkg_contents.

I'm not sure it is actually possible to test Requirement 43. We could check to see that there is at least one row in gpkg_tile_matrix for each row in the contents. However, is a tile matrix set allowed to be empty? If so, then we need to strike the requirement and just have explanatory text.

I think the best way to resolve this is to remove the constraint on "tiles". It should apply to any data type.

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Feb 27, 2017

PR approved by SWG today.

@jyutzler jyutzler closed this Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment