Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator improvements #124

Closed
cholmes opened this issue Oct 24, 2022 · 5 comments
Closed

Validator improvements #124

cholmes opened this issue Oct 24, 2022 · 5 comments
Milestone

Comments

@cholmes
Copy link
Member

cholmes commented Oct 24, 2022

For 1.0.0 we should have a validator that:

  1. Tests not just the metadata but looks at the data itself to make sure it matches the metadata
  2. Is user-friendly, not requiring python. Ideally a web-page and/or an easily installable binary.

This could be building on the current validator in this repo, or could be a new project we reference, but we want to be sure something exists, so putting this issue in to track it.

@cholmes cholmes added this to the 1.0.0-beta.2 milestone Oct 24, 2022
@kylebarron
Copy link
Collaborator

Ideally a web-page

I think that should be possible; parquet-wasm can read just a file's metadata without reading any of the data, so we should at least be able to load the geo metadata from a remote parquet file (or one dragged in) and run a javascript jsonschema checker on it.

I could show how to use the parquet-wasm api, but I don't think I'll have the time to set up the entire webpage

@mrisney
Copy link

mrisney commented Oct 25, 2022

Very happy to hear that parquet-wasm is being consider. Also not sure that "gecommands" are even something that is being thought of, but when using the Geospatial commands of Redis. The brevity of the commands are very easy to use : "redis-geospatial-commands cars my-car robins-car"

@jorisvandenbossche
Copy link
Collaborator

If we want to fully validate a file (i.e. do more than the current validator checking the json schema), we will have to parse the WKB values in the geometry columns.

@m-mohr
Copy link
Collaborator

m-mohr commented Dec 7, 2022

Just a random thought as JSON Schema can't provide this:
The validator should check whether the value of primary_geometry exists as a property key in columns.

@cholmes
Copy link
Member Author

cholmes commented Jul 26, 2023

Closing this, as we've got good validators that check the data itself with GPQ and GDAL/OGR.

GPQ is an easily installable binary, and then you just run gpq validate. I think @tschaub has a plan to put gpq in wasm to do a javascript viewer, but we decided to not block on 1.0 for that.

@cholmes cholmes closed this as completed Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants