Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON Schema version? #127

Closed
m-mohr opened this issue Oct 25, 2022 · 4 comments
Closed

Update JSON Schema version? #127

m-mohr opened this issue Oct 25, 2022 · 4 comments

Comments

@m-mohr
Copy link
Collaborator

m-mohr commented Oct 25, 2022

Just a random thing I noticed while looking through the repo: Not sure whether this comes from the fact that all STAC JSON Schemas are still draft 7, but you may want to consider updating to a more recent version. That should make it a bit more future-proof as you never know when the old JSON Schema versions will be dropped from libraries. Draft-7 is from March 2018 and has been superseeded by draft-2019-09, which itself for superseeded by draft-2020-12.

You are actually already partially into 2019-09 as for example the $defs keyword in the schema was only added in this version.

@m-mohr m-mohr changed the title Update JSON Schema version? Update JSON Schema version? + other notes Oct 25, 2022
@m-mohr m-mohr changed the title Update JSON Schema version? + other notes Update JSON Schema version? Oct 25, 2022
@m-mohr
Copy link
Collaborator Author

m-mohr commented Oct 25, 2022

On the other hand, the referenced PROJJSON schema is also draft-7 so to not mix things too much, keep it conistent?

@kylebarron
Copy link
Collaborator

On the other hand, the referenced PROJJSON schema is also draft-7 so to not mix things too much, keep it conistent?

Seems better to be consistent with theirs? Maybe we should talk to projjson about updating their schema version?

@m-mohr
Copy link
Collaborator Author

m-mohr commented Oct 25, 2022

Yeah, I mean it's all a snowball effect, but we may need to start somewhere. Once PROJJSON updates to a newer version the mix of versions will appear in STAC, for example, where we are still on draft-7 and there we'd need to update dozens of schemas etc. (and we are waiting for the 2022 JSON Schema version for object-based contains) The GeoJSON schemas are also still draft-7... ;-)

@m-mohr
Copy link
Collaborator Author

m-mohr commented Oct 25, 2022

This is a rabbit hole, I better quickly close this issue? 🤣

@m-mohr m-mohr closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants